README: lead with yeet run gh:yeet-src/hotspot - #2
Merged
Merged
Conversation
The one-liner is the intended entrypoint: yeet's source pipeline clones the repo, runs make against its own cache and starts the script, with the BPF toolchain fetched automatically. yeet-src is a trusted origin, so the auto-build runs without a consent prompt. Keep the clone-and-build recipe for people changing the script, and add a FAQ entry for the clone-auth failure, since gh: tries SSH before falling back to HTTPS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julian asked that the entrypoint be
yeet run gh:yeet-src/hotspot. This makes the README match that, and records what I verified while testing it.The blocker (needs a repo admin)
yeet run gh:yeet-src/hotspotcannot work for anyone outside the org until this repo is public. Tested on Debian 13, yeet 0.21.0:The same command against a public yeet-src repo clones anonymously over the HTTPS fallback and works. So visibility is the only thing wrong; nothing in the script needs changing.
I do not have
adminon this repo ({"admin": false, "push": true, "triage": true}), so I could not flip it. The org already permits it (members_can_change_repo_visibility: true) - it just needs someone with admin onyeet-src/hotspot.What I verified works
Against a public Makefile repo, the full remote path runs exactly as the new README describes: clone, then auto-
makein yeet's cache with the toolchain fetched on demand, no consent prompt (yeet-srcis a trusted origin inTRUSTED_URL_PATTERNS), then run.And hotspot itself is healthy, built from a clean tree in the VM:
makefrom scratch: toolchain auto-fetched,bin/probe.bpf.olinked, bundle written tosrc/index.jsx(which the entry ladder prefers oversrc/main.jsx, as intended)demo/cafearms the sampler at 499 Hz scoped to the cgroup and the profile fills in:toilas the hot user frame, withhandle_softirqsand__kernel_clock_gettimetinted and labeledkernelChanges
yeet rundoes the clone and buildgh:tries SSH before falling back to HTTPSNo em-dashes added.